Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): push built images to ghcr.io registry #2632

Closed
wants to merge 1 commit into from

Conversation

nijel
Copy link
Member

@nijel nijel commented Sep 10, 2024

Proposed changes

This is a very small step towards #2589.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Summary by CodeRabbit

  • New Features

    • Enhanced output capabilities for image handling in the build process.
    • Added permissions for package management in multiple workflow jobs, enabling publishing and updating of packages.
  • Bug Fixes

    • Improved interaction with package registries by granting necessary write permissions in workflow configurations.

@nijel nijel enabled auto-merge (rebase) September 10, 2024 07:58
Copy link

coderabbitai bot commented Sep 10, 2024

Walkthrough

The pull request introduces changes to multiple GitHub Actions workflow files and a shell script. It adds new output functionality to a shell script for image handling and modifies the permissions for jobs in two workflow files to enable writing to package registries. These changes enhance the workflows' capabilities related to package management and image processing without altering existing logic.

Changes

Files Change Summary
.github/bin/get-buildx-args Added an echo command to output image type and push directive with GITHUB_RUN_ID.
.github/workflows/bleeding.yml Added permissions: packages: write to build and buildx jobs.
.github/workflows/dockerimage.yml Added permissions: packages: write to build and buildx jobs.

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7f73756 and 546497a.

Files selected for processing (3)
  • .github/bin/get-buildx-args (1 hunks)
  • .github/workflows/bleeding.yml (2 hunks)
  • .github/workflows/dockerimage.yml (2 hunks)
Additional comments not posted (5)
.github/bin/get-buildx-args (1)

67-67: LGTM, but verify the impact on image repositories.

The code changes are approved.

However, ensure that this change is thoroughly tested to confirm that it behaves as expected and does not adversely affect the interaction with image repositories.

Run the following script to verify the impact on image repositories:

.github/workflows/dockerimage.yml (2)

21-22: LGTM!

The code changes are approved.


45-46: LGTM!

The code changes are approved.

.github/workflows/bleeding.yml (2)

31-32: LGTM!

The code changes are approved.


59-60: LGTM!

The code changes are approved.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nijel nijel closed this Sep 10, 2024
auto-merge was automatically disabled September 10, 2024 08:36

Pull request was closed

@nijel nijel deleted the ci-push branch September 10, 2024 08:36
@nijel
Copy link
Member Author

nijel commented Sep 10, 2024

Okay, this doesn't work for pull requests, what makes #2589 a bit more tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant