-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #231
Update #231
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really prefer to keep the scripts as simple as possible, so I'd drop support for docker-compose
and support docker compose
only. I've just done that in #232. The yaml files changes are mostly not desired.
@@ -2,6 +2,9 @@ version: '3' | |||
services: | |||
weblate: | |||
image: weblate/weblate | |||
# To use a custom port, change the first 8080 to your port | |||
ports: | |||
- 8080:8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to expose port here, it is done via https-portal
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to expose port here, it is done via
https-portal
below.
Yes, I could not access Weblate until I published the ports
@@ -19,14 +22,14 @@ services: | |||
WEBLATE_ENABLE_HTTPS: 1 | |||
WEBLATE_IP_PROXY_HEADER: HTTP_X_FORWARDED_FOR | |||
database: | |||
image: postgres:16-alpine | |||
image: postgres:16.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think pinning major version is not good enough here? We're not really playing on the exact environment here (Weblate itself is not pinned at all).
Also, I don't see a reason for stopping using alpine variant, which is smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think pinning major version is not good enough here?
Because 16.2 is newer than 16!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 16 is a moving tag for the latest release in 16.x series, see https://hub.docker.com/_/postgres.
And I also ask for removal of the -alpine
suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 16 is a moving tag for the latest release in 16.x series, see https://hub.docker.com/_/postgres.
So, the 16 tag automatically takes the latest sub-version of the 16.x series?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That how it works for most of the Docker images.
No description provided.