Fix undefined attachment name when headers use "filename*=" format #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webklex
added a commit
that referenced
this pull request
Jan 2, 2023
|
Hi @JulienChavee , Best regards and a happy new year, |
|
Hello @Webklex Thank you for taking time to review the pull requests, and I am glad that you were able to merge it on your side :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A little PR as a first step to fix attachment names being set as "undefined" if the header uses the format "filename*=".
I've also added some unit tests to cover the change I made (and updated to phpunit version).
Feel free to review it and drop any comments :)