Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments - method getId can return empty value #318

Closed
uiozgadaniel opened this issue Nov 7, 2022 · 2 comments
Closed

Attachments - method getId can return empty value #318

uiozgadaniel opened this issue Nov 7, 2022 · 2 comments
Labels
bug Something isn't working validated

Comments

@uiozgadaniel
Copy link

Bug description
During use of Webklex PHP Imap I encountered a problem with non-incoming attachments.
After debugging I found a problem with attachment ID in Message.php file on line 592:
https://github.com/Webklex/php-imap/blob/master/src/Message.php#L592
In my case getId method 4 out of 7 attachments, returns an empty value (an empty string value).

Bug result
Not all attachments are saved by missing attachments in the message.

Proposed solution
One of solution can be changing this line to:

...
if (!empty($oAttachment->getId())) { 
    ....

Is there a chance to improve this part of code?

@Webklex Webklex added bug Something isn't working validated labels Nov 28, 2022
@Webklex
Copy link
Owner

Webklex commented Nov 28, 2022

Hi @uiozgadaniel ,
many thanks for your report!

Best regards,

@uiozgadaniel
Copy link
Author

Thank you, you're doing well! Have a nice day! ;)

@Webklex Webklex closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validated
Projects
None yet
Development

No branches or pull requests

2 participants