Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MDNS.update() in update() #58

Closed
willdurand opened this issue Mar 17, 2019 · 2 comments
Closed

Missing MDNS.update() in update() #58

willdurand opened this issue Mar 17, 2019 · 2 comments

Comments

@willdurand
Copy link

willdurand commented Mar 17, 2019

Hi,

using the latest Arduino 2.5.0 library and any example from this library (e.g., the LED sketch), mDNS does not work anymore: no device can be reached via its <hostname>.local domain.

According to this comment, there should be a call to MDNS.update() in the loop() so this call should be added to https://github.com/mozilla-iot/webthing-arduino/blob/305860fdd3aba08914c4f5d2d82d17eadc9617e5/ESPWebThingAdapter.h#L74-L76.

If I add MDNS.update() in the loop() of the LED sketch, the device is reachable again (via ping w25.local). The LWIP version does not matter (I tried v2 and v1.4).

@hobinjk
Copy link
Contributor

hobinjk commented Mar 18, 2019

Thanks for bringing this up! I was wondering why we hadn't had an issue previously and reading through that issue was fascinating

@willdurand
Copy link
Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants