Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration test for aid to join multisig #258

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

daviddm
Copy link
Contributor

@daviddm daviddm commented May 8, 2024

This PR includes multisig test join and illustrates the problem in #227.

The integration test creates a multisig-group with 2 members and threshold 1.
Member 1 adds a new member(member3) to the group and does a double rotation for the new member to be able to join and add the end-role by himself.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (850af59) to head (ccd6aee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files          48       48           
  Lines        4229     4229           
  Branches     1034     1021   -13     
=======================================
  Hits         3545     3545           
- Misses        656      680   +24     
+ Partials       28        4   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2byrds
Copy link
Contributor

2byrds commented Jul 8, 2024

Cross-posting here, I tested this against this PR WebOfTrust/keria#254 and it was successful. Once 'keria:latest' is updated, this test should pass.

@lenkan
Copy link
Collaborator

lenkan commented Jul 8, 2024

Also, if we were to pull WebOfTrust/keria@caad67b and patch 0.1.x of keria, we could merge this without having to upgrade to keria 0.2.x.

@2byrds
Copy link
Contributor

2byrds commented Jul 22, 2024

Cross-posting here, I tested this against this PR WebOfTrust/keria#254 and it was successful. Once 'keria:latest' is updated, this test should pass.

@daviddm if you would like to rerun these checks, KERIA:latest should have the fixes needed:
https://hub.docker.com/r/weboftrust/keria/tags
Although I'm aware that the cherry pick option that @lenkan points might be preferred at this point.

@lenkan
Copy link
Collaborator

lenkan commented Aug 12, 2024

@daviddm @2byrds I have rebased the branch and re-ran the test, it passes now.

@2byrds
Copy link
Contributor

2byrds commented Aug 12, 2024

@daviddm @2byrds I have rebased the branch and re-ran the test, it passes now.

Excellent! Can it be merged @lenkan ?

@lenkan lenkan self-requested a review August 12, 2024 15:20
@lenkan
Copy link
Collaborator

lenkan commented Aug 12, 2024

@daviddm @2byrds I have rebased the branch and re-ran the test, it passes now.

Excellent! Can it be merged @lenkan ?

Yes, just wanted to await any reviews.

@lenkan lenkan merged commit ce3614c into WebOfTrust:main Aug 14, 2024
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants