Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autosignin #83

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion example-web/my-app/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ function App() {
};

const handleSyncRequest = async () => {
// TODO extension Id harcoded just for testing, need to find a way to get it dynamically
const { data, error } = await chrome.runtime.sendMessage(extensionId, {
type: "fetch-resource",
subtype: "auto-signin-signature",
Expand Down
2 changes: 1 addition & 1 deletion src/pages/background/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ chrome.runtime.onMessageExternal.addListener(function (

const signedHeaders = await signifyService.signHeaders(
// sigin can either have identifier or credential
autoSignin?.identifier.name ?? autoSignin?.credential?.schema?.title,
autoSignin?.identifier? autoSignin?.identifier.name : autoSignin?.credential?.issueeName,
origin
);
let jsonHeaders: { [key: string]: string } = {};
Expand Down
1 change: 0 additions & 1 deletion src/pages/dialog/signin.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { TAB_STATE } from "@pages/popup/constants";
import { setTabState } from "@pages/content/index";

// TODO do not pass the full signins stored object (only AID name, schema name, web url)
export const SigninItem = ({ signin }: { signin: any }): JSX.Element => {
const handleClick = async () => {
const headers = await chrome.runtime.sendMessage({
Expand Down