Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/input #144

Merged
merged 2 commits into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions src/components/createIdentifierCard.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { isValidElement, useState, useEffect } from "react";
import { useState, useEffect } from "react";
import { useIntl } from "react-intl";
import { Button } from "@components/ui";
import { Button, Input } from "@components/ui";
import { hasWhiteSpace, removeWhiteSpace } from "@pages/background/utils";

interface ICreateIdentifierCard {
Expand Down Expand Up @@ -35,7 +35,7 @@ export function CreateIdentifierCard(
hasError = true;
} else if (hasWhiteSpace(name)) {
setNameError(
<div className="text-red mt-1">
<div className="text-red text-xs mt-1">
{formatMessage({ id: "identifier.error.noWhiteSpace" })}{" "}
<button
className=" underline cursor-pointer"
Expand All @@ -62,24 +62,14 @@ export function CreateIdentifierCard(
className=" max-w-xs m-4 flex flex-col gap-y-4"
>
<div>
<input
<Input
type="text"
id="vendor_url"
className={`border text-black text-sm rounded-lg block w-full p-2.5 ${
nameError ? " text-red border-red" : ""
} `}
error={nameError}
placeholder={formatMessage({ id: "identifier.uniqueName" })}
required
value={name}
onChange={(e) => setName(e.target.value)}
/>
{nameError ? (
isValidElement(nameError) ? (
nameError
) : (
<p className="text-red mt-1">{nameError}</p>
)
) : null}
</div>
<div className=" flex flex-row justify-center mt-2">
<Button
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/dropdown/dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const DropdownWrapper = styled.div<Pick<IDropdown, "zIndex">>`
`;

const DropdownButton = styled.button`
padding: 10px;
padding: 8px;
border: none;
cursor: pointer;
width: 100%;
Expand Down
1 change: 1 addition & 0 deletions src/components/ui/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ export * from "./dropdown";
export * from "./radio";
export * from "./switch";
export * from "./loader";
export * from "./input";
1 change: 1 addition & 0 deletions src/components/ui/input/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { Input } from "./input";
73 changes: 73 additions & 0 deletions src/components/ui/input/input.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
import React, { isValidElement } from "react";
import styled from "styled-components";

interface IInput {
label?: string;
placeholder?: string;
error?: string | JSX.Element;
id: string;
required?: boolean;
value?: string;
onChange?: (e: React.ChangeEvent<HTMLInputElement>) => void;
onBlur?: () => void;
type?: string;
}

const StyledInput = styled.input<Pick<IInput, "error">>`
border-radius: 4px;
display: block;
width: 100%;
padding: 8px;
border: ${({ theme, error }) =>
`1px solid ${error ? theme?.colors?.error : theme?.colors?.bodyBorder}`};
background-color: ${({ theme }) => theme?.colors?.bodyBg};
color: ${({ theme, error }) =>
error ? theme?.colors?.error : theme?.colors?.bodyColor};
`;

const StyledInputError = styled.p`
color: ${({ theme }) => theme?.colors?.error};
font-size: 12px;
`;

export const Input = ({
label,
placeholder,
error,
id,
required,
value,
onChange,
onBlur,
type = "text",
}: IInput) => {
return (
<div>
{label ? (
<label htmlFor={id} className="text-sm font-bold">
{label}
</label>
) : (
<></>
)}
<StyledInput
type={type}
id={id}
className={`text-black text-sm `}
error={error}
placeholder={placeholder}
required={required}
value={value}
onChange={onChange}
onBlur={onBlur}
/>
{error ? (
isValidElement(error) ? (
error
) : (
<StyledInputError>{error}</StyledInputError>
)
) : null}
</div>
);
};
28 changes: 7 additions & 21 deletions src/screens/config/config.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useIntl } from "react-intl";
import { configService } from "@pages/background/services/config";
import { useLocale, languageCodeMap } from "@src/_locales";
import { isValidUrl, setActionIcon } from "@pages/background/utils";
import { Button, Dropdown } from "@components/ui";
import { Button, Dropdown, Input } from "@components/ui";

const langMap = Object.entries(languageCodeMap).map((s) => ({
label: s[1],
Expand Down Expand Up @@ -115,22 +115,15 @@ export function Config(props: any): JSX.Element {
return (
<>
<div className="px-4 relative mb-2">
<p className="text-sm font-bold">
{formatMessage({ id: "config.vendorUrl.label" })}
</p>
<input
type="text"
<Input
id="vendor_url"
className={`border text-black text-sm rounded-lg block w-full p-2.5 ${
vendorUrlError ? " text-red border-red" : ""
} `}
label={formatMessage({ id: "config.vendorUrl.label" })}
error={vendorUrlError}
placeholder={formatMessage({ id: "config.vendorUrl.placeholder" })}
required
value={vendorUrl}
onChange={(e) => setVendorUrl(e.target.value)}
onBlur={checkErrorVendorUrl}
/>
{vendorUrlError ? <p className="text-red">{vendorUrlError}</p> : null}
<div className="absolute right-[16px] bottom-[-28px]">
<Button
handleClick={handleSave}
Expand All @@ -143,22 +136,15 @@ export function Config(props: any): JSX.Element {
</div>
</div>
<div className="px-4">
<p className="text-sm font-bold">
{formatMessage({ id: "config.agentUrl.label" })} *
</p>
<input
type="text"
<Input
id="agent_url"
className={`border text-black text-sm rounded-lg block w-full p-2.5 ${
agentUrlError ? " text-red border-red" : ""
} `}
label={`${formatMessage({ id: "config.agentUrl.label" })} *`}
error={agentUrlError}
placeholder={formatMessage({ id: "config.agentUrl.placeholder" })}
required
value={agentUrl}
onChange={(e) => setAgentUrl(e.target.value)}
onBlur={() => handleSetAgentUrl(agentUrl)}
/>
{agentUrlError ? <p className="text-red">{agentUrlError}</p> : null}
</div>
<div className="px-4">
<p className="text-sm font-bold">
Expand Down
10 changes: 3 additions & 7 deletions src/screens/signin/signin.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState, useEffect } from "react";
import { Button } from "@components/ui";
import { Button, Input } from "@components/ui";
import { useIntl } from "react-intl";

interface ISignin {
Expand Down Expand Up @@ -49,19 +49,15 @@ export function Signin(props: ISignin): JSX.Element {
<img src={props.logo} className="w-32 h-32" alt="logo" />
</div>
<div className=" px-4 py-2">
<input
<Input
type="password"
id="passcode"
className={`border text-black text-sm rounded-lg block w-full p-2.5 ${
passcodeError ? " text-red border-red" : ""
}`}
error={passcodeError}
placeholder={passcodeMessage}
required
value={passcode}
onChange={(e) => setPasscode(e.target.value)}
onBlur={onBlurPasscode}
/>
{passcodeError ? <p className="text-red">{passcodeError}</p> : null}
</div>
<div className="flex flex-row justify-center">
<Button
Expand Down
16 changes: 5 additions & 11 deletions src/screens/signup/signup.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState, useEffect } from "react";
import styled, { css } from "styled-components";
import { useIntl } from "react-intl";
import { Card, Button, Text } from "@components/ui";
import { Card, Button, Text, Input } from "@components/ui";
import EyeIcon from "@components/shared/icons/eye";
import EyeOffIcon from "@components/shared/icons/eye-off";
import { IMessage } from "@config/types";
Expand All @@ -13,11 +13,11 @@ interface ISignup {
}

const StyledGeneratedPassword = styled.p<{ blur: boolean }>`
${({ blur }) =>
${({ blur, theme }) =>
blur &&
css`
color: transparent;
text-shadow: 0 0 8px #000;
text-shadow: 0 0 8px ${theme?.colors?.cardColor};
`}
`;

Expand Down Expand Up @@ -131,21 +131,15 @@ export function Signup({
copiedToClipboard ? (
<div>
<div className="mb-1">
<input
<Input
type="password"
id="passcode"
className={`border text-black text-sm rounded-lg block w-full p-1 ${
passcodeError ? " text-red border-red" : ""
}`}
error={passcodeError}
placeholder={passcodeMessage}
required
value={passcode}
onChange={(e) => setPasscode(e.target.value)}
onBlur={onBlurPasscode}
/>
{passcodeError ? (
<p className="text-red">{passcodeError}</p>
) : null}
</div>
<Button
isLoading={isLoading}
Expand Down