Merge pull request #83 from rodolfomiranda/small_fixes

fix autosignin
WebOfTrust · Jan 24, 2024 · ae7b32e · ae7b32e
2 parents 9fa781e + 5a04111
commit ae7b32e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/example-web/my-app/src/App.js b/example-web/my-app/src/App.js
@@ -39,7 +39,6 @@ function App() {
   };
 
   const handleSyncRequest = async () => {
-    // TODO extension Id harcoded just for testing, need to find a way to get it dynamically
     const { data, error } = await chrome.runtime.sendMessage(extensionId, {
       type: "fetch-resource",
       subtype: "auto-signin-signature",

diff --git a/src/pages/background/index.ts b/src/pages/background/index.ts
@@ -249,7 +249,7 @@ chrome.runtime.onMessageExternal.addListener(function (
 
       const signedHeaders = await signifyService.signHeaders(
         // sigin can either have identifier or credential
-        autoSignin?.identifier.name ?? autoSignin?.credential?.schema?.title,
+        autoSignin?.identifier? autoSignin?.identifier.name : autoSignin?.credential?.issueeName,
         origin
       );
       let jsonHeaders: { [key: string]: string } = {};

diff --git a/src/pages/dialog/signin.tsx b/src/pages/dialog/signin.tsx
@@ -1,7 +1,6 @@
 import { TAB_STATE } from "@pages/popup/constants";
 import { setTabState } from "@pages/content/index";
 
-// TODO do not pass the full signins stored object (only AID name, schema name, web url)
 export const SigninItem = ({ signin }: { signin: any }): JSX.Element => {
   const handleClick = async () => {
     const headers = await chrome.runtime.sendMessage({