Fix for failing Reply End Roles escrows #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodolfomiranda
changed the title
pfeairheller
requested changes
Apr 4, 2024
src/keri/core/eventing.py
Outdated
| @@ -4285,6 +4285,7 @@ def processReplyEndRole(self, *, serder, saider, route, | |||
| aid = cid # authorizing attribution id | |||
| keys = (aid, role, eid) | |||
| osaider = self.db.eans.get(keys=keys) # get old said if any | |||
| if osaider is not None and osaider.qb64b == saider.qb64b: osaider = None | |||
There was a problem hiding this comment.
2 things...
- please wrap if statements like this otherwise it triggers a PEP warning.
- We need to discuss this as I believe this breaks BADA RUN logic.
There was a problem hiding this comment.
1- done
2- Yes, I need your careful review. I think it is not breaking bada run since it's preventing to compare the same said (old = new), so you'll be updating/authorizing the same aid-role-eid value again.
I hit that problem working with a multisig in KERIA/Signify, and the problem is an escrow that never completes. Not sure if that can be part of a unit test. I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when escrowing reply end roles, a race condition causes that the updated
endin the db is interpreted as an old end, and then the validation failed because the datetime of the new message has not increased. When that happens, the escrow of the reply message can not be confirmed and fails until timeouts.In this PR I'm adding a validation to make sure that the end retrieved from the DB is actually an old end and not the same that we are trying to authorize.