Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: serials to kinds and upgrade to keripy version #294

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Sep 11, 2024

Supersedes #275 - same changes, just pointing to the correct dev release.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (18d3ad7) to head (8cf7225).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   93.06%   93.68%   +0.62%     
==========================================
  Files          36       36              
  Lines        7121     7859     +738     
==========================================
+ Hits         6627     7363     +736     
- Misses        494      496       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iFergal
Copy link
Contributor Author

iFergal commented Sep 11, 2024

cc @m00sey

@kentbull
Copy link
Contributor

This looks like a duplicate of #275

@iFergal
Copy link
Contributor Author

iFergal commented Sep 17, 2024

@kentbull It's an intentional duplicate to make the tests pass, based off of the other PR as I couldn't push to Sam's fork. So once merged the other one should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants