Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send multi-sig admit to to discloser not issuer #286

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Aug 28, 2024

Not always the same!

Closes #279

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (18d3ad7) to head (4262ba3).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   93.06%   93.17%   +0.11%     
==========================================
  Files          36       36              
  Lines        7121     7738     +617     
==========================================
+ Hits         6627     7210     +583     
- Misses        494      528      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2byrds 2byrds merged commit 70209b2 into WebOfTrust:main Aug 28, 2024
5 checks passed
@iFergal iFergal deleted the fix/sendMultisigAdmitToGranterNotIssuer branch August 29, 2024 07:36
@lenkan
Copy link
Contributor

lenkan commented Aug 29, 2024

@iFergal I am curious, what was the end implication of this? Did the admit still go through and the "admitter" would have the credential stored anyway?

Would be nice to have test coverage for these type of things 😬

@iFergal
Copy link
Contributor Author

iFergal commented Aug 29, 2024

@lenkan It didn't affect the credential issuance flow. If you were doing a multi-sig admit in response to a grant from an issuer, the credential was always stored because the granter and issuer are the same.

The problem is if it's a multi-sig presentation - the admit was being sent to the issuer instead of the presenter.

But yeah, agreed I'll try to capture it in the tests and open a PR.

@kentbull
Copy link
Contributor

kentbull commented Sep 9, 2024

So grant.ked['i'] refers to the discloser of an IPEX Grant and grant.ked["e"]["acdc"]["i"] refers. to the issuer of the ACDC?

@iFergal
Copy link
Contributor Author

iFergal commented Sep 9, 2024

@kentbull yep!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-sig IPEX admit should use i field of exn over ACDC issuer
4 participants