Allowing prefixes in identifiers endpoint #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 36 36
Lines 7121 7198 +77
=======================================
+ Hits 6627 6699 +72
- Misses 494 499 +5 ☔ View full report in Codecov by Sentry. |
pfeairheller
requested changes
Jul 11, 2024
…ing (WebOfTrust#256) * Increase Escrower tock to avoid overly busy CPU during escrow processing Setting tock to 1.0 second runs escrower loop 30s delay and delegator approval received after 30 seconds * Remove redundant looping inside escrower recur method --------- Co-authored-by: Rubel Hassan Mollik <[email protected]>
…rust#265) * Make agent doers' tocks configurable from habitat config file * Fix typo of naming in test_load_tocks_config --------- Co-authored-by: Rubel Hassan Mollik <[email protected]> Co-authored-by: Philip Feairheller <[email protected]>
|
I screw up the PR when rebasing. It picked other commits. I created a new clean one in #269 and I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of #217 and #202, fixing the problem of aliases with special characters .
The changes allow endpoints of the form
/identifiers/{name}to accept an alias or a prefix in the name path. If the value is valid for both prefix and alias, the prefix is prioritized.Basically, the PR replace:
hab = agent.hby.habByName(name)with
hab = agent.hby.habs[name] if name in agent.hby.habs else agent.hby.habByName(name)