Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anyhow #134

Merged
merged 1 commit into from
Mar 15, 2023
Merged

anyhow #134

merged 1 commit into from
Mar 15, 2023

Conversation

jasoncolburne
Copy link
Collaborator

@jasoncolburne jasoncolburne commented Mar 14, 2023

Rationale

This makes it easier to consume errors from our library.

We likely want to eventually wrap all errors with our own to provide a consistent interface.

Screenshots (attempted integration)

Screenshot 2023-03-14 at 8 15 16 AM

Changes

Removes boxed errors and introduces anyhow for similar functionality.

Testing

Integrated with another library, and also:

make fix clean preflight

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #134 (812cc66) into main (d0d1dd6) will not change coverage.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          29       29           
  Lines        2795     2795           
=======================================
  Hits         2664     2664           
  Misses        131      131           
Impacted Files Coverage Δ
src/data.rs 96.87% <ø> (ø)
src/error.rs 25.00% <0.00%> (ø)
src/core/indexer/tables.rs 100.00% <100.00%> (ø)
src/core/tholder.rs 99.06% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasoncolburne jasoncolburne marked this pull request as ready for review March 14, 2023 11:26
@jasoncolburne jasoncolburne merged commit 89cd0cc into WebOfTrust:main Mar 15, 2023
@jasoncolburne jasoncolburne deleted the anyhow branch March 15, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants