base64 encode_slice() #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncolburne
force-pushed
the
base64-encoding
branch
from
14ebcd1
to
c39f525
Compare
jasoncolburne
commented
Mar 10, 2023
src/core/tholder.rs
Outdated
| @@ -36,7 +36,7 @@ fn values_to_rationals(value: &Value) -> Result<Vec<Vec<Rational32>>> { | |||
| let _clause = _clause.to_vec()?; | |||
| for weight in _clause { | |||
| let weight = weight.to_string()?; | |||
| let parts: Vec<&str> = weight.split(separator).into_iter().collect(); | |||
There was a problem hiding this comment.
Changes in this file were due to linter updates, they are also included in #127
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 95.30% 95.31%
=======================================
Files 29 29
Lines 2791 2795 +4
=======================================
+ Hits 2660 2664 +4
Misses 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
m00sey
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR addresses #129. I think it only really matters in
Matter, since that's what Signer and Salter are based upon. If we think it makes sense we can change throughout the library to be consistent with preallocation, but we won't need the zeroization code so it won't look exactly the same anyway.Changes
Uses zeroizing, preallocated vecs and
encode_slice()to do minimal allocations and clear sensitive memory.Testing