Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.eslintrc doesn't fully match WP Code standards #230

Closed
Cheffheid opened this issue Dec 15, 2016 · 1 comment
Closed

.eslintrc doesn't fully match WP Code standards #230

Cheffheid opened this issue Dec 15, 2016 · 1 comment

Comments

@Cheffheid
Copy link
Contributor

Cheffheid commented Dec 15, 2016 •
edited
Loading

The WordPress config that's extended will, eventually, add missing rulesets as per their roadmap (See here: WordPress-Coding-Standards/eslint-config-wordpress#8).

In the mean time, it'll be worth while to add the rules slated for V2.0.0 manually, since those will also look at coding style errors like spaces inside of parenthesis, mixed spaces/tabs, etc.
@gregrickaby
Copy link
Contributor

While we're at it, .eslintrc has been deprecated. Let's rename to either .eslintrc.js or .eslintrc.yml.

http://eslint.org/docs/user-guide/configuring#configuration-file-formats

@Cheffheid Cheffheid mentioned this issue Dec 16, 2016
Merged
gregrickaby pushed a commit that referenced this issue Dec 17, 2016
@Cheffheid @gregrickaby
Rename and Update .eslintrc config file. Fixes #230. Props @Cheffheid
900c93d 
* Rename .eslintrc config file to .js

* Add JS syntax to set ESLint config

* Add WP codestyle rules to ESLint config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregrickaby @Cheffheid