Fix typo in multi.c: args should be i32, i64, i64, i32
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
👍 |
bors bot
added a commit
to wasmerio/wasmer
that referenced
this pull request
Dec 21, 2020
1953: Get `multi.c` working in the Wasm C API r=MarkMcCaskey a=MarkMcCaskey Gets the `multi.c` example working. This PR has significant overlap with #1949 due to changes in vec / boxed vec. Changes in this PR: - impl `Clone` more often, implement `*_copy` functions in terms of `Clone` - clean up boxed vec behavior - add `*_vec_copy` functions for boxed and unboxed versions - fix a typo in `wasm-c-api/examples/multi.c`; fixed in the upstream Wasm C API here: WebAssembly/wasm-c-api#163 - additional misc improvements # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while trying to run this example. Looks like it was accidentally changed to
i32, i32, i32, i32in a refactor. This makesmulti.cdo the same thing thatmulti.ccis doing.