feat: Add wasm_module_name and wasm_module_set_name.
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Oct 12, 2020
I submited a proposal to the official `wasm.h` by the way, WebAssembly/wasm-c-api#157. For the moment, let's keep that as a vendor specific implementation.
This patch proposes 2 new functions to handle module's name: * `wasm_module_name` that writes the module's name in a `wasm_name_t` if any, * `wasm_module_set_name` that sets the module's name if possible. `wasm_module_set_name` returns `true` if the module's name has been updated succesfully, `false` otherwise, e.g. if the name is invalid, or if it's not possible to update it (e.g. if the module is already instantiated).
Hywan
force-pushed
the
feat-module-name
branch
from
029434b to
3f58682
Compare
|
Hm, there is no such concept as a module's name in Wasm. So this would be a custom notion. But if you want to attach custom data to a module object, you already can by using |
|
Some context: We use Wasm names to identify the wasm modules when debugging. |
|
What I call “name” is |
bors bot
added a commit
to wasmerio/wasmer
that referenced
this pull request
Oct 13, 2020
1709: feat(c-api) Implement `wasm_module_name` and `wasm_module_set_name` r=Hywan a=Hywan Until my official proposal made here, WebAssembly/wasm-c-api#157 is accepted or rejected, I implement those functions as “wasmer-specific” API. Co-authored-by: Ivan Enderlin <[email protected]>
|
But that is just an artefact of the text format, it is not represented in the binary format (outside custom sections). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proposes 2 new functions to handle module's name:
wasm_module_namethat writes the module's name in awasm_name_tif any,
wasm_module_set_namethat sets the module's name if possible.wasm_module_set_namereturnstrueif the module's name has beenupdated succesfully,
falseotherwise, e.g. if the name is invalid,or if it's not possible to update it (e.g. if the module is already
instantiated).