feat: wasm_name_new_from_string* owns s
#155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wasm_name_new` is an alias to `wasm_byte_vec_new`, which owns the `ptr_or_none` argument, which is in this case `s`. This patch adds the `own` market to `wasm_name_new_from_string` and `wasm_name_new_from_string_nt`.
|
Oh, ouch. I see there is an inconsistency there. Unfortunately, I think this is the wrong fix. These constructors don't take ownership of the string in the implementation, nor should they -- you wouldn't be able to create a name form a string literal, for example. It's the definition of I think the right fix would be to move the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm_name_newis an alias towasm_byte_vec_new, which owns theptr_or_noneargument, which is in this cases.This patch adds the
ownmarket towasm_name_new_from_stringandwasm_name_new_from_string_nt.