Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope-id as part of Ipv6Address #2

Closed
badeend opened this issue Mar 1, 2022 · 3 comments
Closed

scope-id as part of Ipv6Address #2

badeend opened this issue Mar 1, 2022 · 3 comments

Comments

@badeend
Copy link
Collaborator

badeend commented Mar 1, 2022

Should the scope-id be moved out of Ipv6SocketAddress and into Ipv6Address? It seems logical that wherever the IPv6 address flows, the scope-id should flow too. This is the way Java and .NET have implemented it.
@sunfishcode
Copy link
Member

In the OS APIs, the scope id is associated with socket addresses, rather than IPv6 addresses. For example, in RFC2553, it's in the sockaddr_in6 struct: https://datatracker.ietf.org/doc/html/rfc2553#section-3.3. I suggest having WASI-sockets follow that, so that we don't ever end up with interfaces where the WASI version accepts a scope ID when the corresponding OS API doesn't.

@rwally1986
Copy link

One side issue, JAVA under version 9, drops packets and sometime fails IPv6 connections. Strongly suggest the community move to Java 17.

badeend pushed a commit to badeend/wasi-sockets that referenced this issue Feb 25, 2023
@linclark
Merge pull request WebAssembly#2 from sunfishcode/main
eafa66d 
Update to the latest wit-bindgen.
badeend pushed a commit to badeend/wasi-sockets that referenced this issue Feb 25, 2023
@sunfishcode
Remove stale files. (WebAssembly#3)
2070f4a 
Delete files that I included by accident in WebAssembly#2. The real files are named
`wasi-proposal-template.*`.
@badeend
Copy link
Collaborator Author

badeend commented Apr 3, 2023

Closing. No discussion for a while and I agree with @ sunfishcode

@badeend badeend closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@badeend @sunfishcode @rwally1986