Build libcxxabi and libcxx with threads enabled#301
Merged
sunfishcode merged 1 commit intoWebAssembly:mainfrom Mar 16, 2023
Merged
Build libcxxabi and libcxx with threads enabled#301sunfishcode merged 1 commit intoWebAssembly:mainfrom
sunfishcode merged 1 commit intoWebAssembly:mainfrom
Conversation
whitequark
force-pushed
the
threads-libcxxabi-libcxx
branch
from
34795ae to
f6153f4
Compare
Contributor
Author
whitequark
force-pushed
the
threads-libcxxabi-libcxx
branch
from
f6153f4 to
ac5d8fa
Compare
Collaborator
|
@whitequark, thanks for this PR! I am fine with this but I feel like @sunfishcode should take a look: do we want to merge this in |
Member
|
Looks good to me! |
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Jul 5, 2023
pkgsCross.wasi32.llvmPackages: 12 -> 16 * It appears BULK_MEMORY_SOURCES no longer needs to be set to be empty to compile firefox. Without it, the build of wasilibc would fail if enableThreads is true. * Include preliminary support for the experimental threads support in wasilibc which provides pthreads API. If wasilibc is built with support, is exposed via passthru and libcxx / libcxxabi are built with threads support accordingly. See also: - WebAssembly/wasi-sdk#274 - WebAssembly/wasi-sdk#301 - WebAssembly/wasi-sdk#314 wasi-sdk ships it by default, but as a separate variant of libc which would be a hassle for us. Let's just make it optional for now. You can try it out using the following overlay: self: super: { wasilibc = super.wasilibc.override { enableThreads = true; }; } Flags for libc++abi are copied from wasi-sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on WebAssembly/wasi-libc#397.