Conversation
This brings in two recent commits, WebAssembly/wasi-libc#388 and WebAssembly/wasi-libc#391, that seem useful to have.
This change updates the `src/llvm-project` submodule to LLVM 16. It uses the same commit as the one in LLVM's own 16.0.0-rc1 [pre-release]. [pre-release]: https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.0-rc1
|
Are we sure we want to use a pre-release here? Is that something we have done before? |
|
The point of this PR is to prepare a pre-release that has the needed LLVM 16 features and support for the new If you don't think we should update to LLVM's |
|
Landing on a branch until the official release sgtm. |
|
I tried bumping LLVM to 16.0.0-rc2 in wasi-sdk, and get this error when calling
EDIT: the same errors have been reproduced by CI on this branch. EDIT: ah I see, https://reviews.llvm.org/D125860. so it's expected behavior. the wasi-sdk Makefile should be patched to correct the install prefix of clang_rt to only use major version number. |
Due to [a change] in LLVM, Clang will expect to find the `libclang_rt.builtins-wasm32.a` file in a path that only contains the major version (`16`) instead of the entire version (`16.0.0`) as was previously the case. This change modifies the `CMAKE_INSTALL_PREFIX` to use Clang's major version only. [a change]: https://reviews.llvm.org/D125860
While this branch was building, LLVM pre-released [rc2]. This commit tries that out. [rc2]: https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.0-rc2
| -DLLVM_CONFIG_PATH=$(ROOT_DIR)/build/llvm/bin/llvm-config \ | ||
| -DCOMPILER_RT_OS_DIR=wasi \ | ||
| -DCMAKE_INSTALL_PREFIX=$(PREFIX)/lib/clang/$(CLANG_VERSION)/ \ | ||
| -DCMAKE_INSTALL_PREFIX=$(PREFIX)/lib/clang/$(CLANG_MAJOR_VERSION)/ \ |
There was a problem hiding this comment.
i suppose you can use clang -print-resource-dir
|
Closing, this is superceded by #296. |
4 participants
This change updates the
src/llvm-projectsubmodule to LLVM 16. It uses the same commit as the one in LLVM's own 16.0.0-rc1 pre-release. It also updates thesrc/wasi-libcsubmodule with some recent commits, WebAssembly/wasi-libc#388 and WebAssembly/wasi-libc#391, that seem useful to have.