Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next release of wasi-sdk-22 #408

Closed
alexcrichton opened this issue Apr 12, 2024 · 9 comments
Closed

Next release of wasi-sdk-22 #408

alexcrichton opened this issue Apr 12, 2024 · 9 comments

Comments

@alexcrichton
Copy link
Collaborator

I wanted to open this up and see if anyone had any objections to publishing a v22 release for wasi-sdk. I'm happy to drive using the instructions @abrown has added, but wanted to make sure beforehand there were no objections.
@sunfishcode
Copy link
Member

Sounds good to me.

@alexcrichton
Copy link
Collaborator Author

I've created a tag which has kicked off a build

@alexcrichton
Copy link
Collaborator Author

The release artifacts are not built correctly so I've deleted the tag.

One issue is #409 where ./version.py was putting a git hash in the version number when it shouldn't. Another issue is CI built artifacts with a version number of 21.21... which should have been 22.0... and I am trying to figure out why and am being pretty unsuccessful.

alexcrichton added a commit to alexcrichton/wasi-sdk that referenced this issue Apr 12, 2024
@alexcrichton
Force-fetch tags in CI to fix git describe
3453913 
My release attempt in WebAssembly#408 did not go well because the release artifacts
were not named correctly. This fixes an issue described by
actions/checkout#290 where checkouts of annotated tags overwrite the
annotation which breaks `git describe`. That means that version
detection is broken in CI during releases which causes artifacts to have
the wrong information.

This applies the workaround described in that issue to `git fetch --tags
--force` after the checkout step to undo the overwrite done in the
checkout step.
@alexcrichton alexcrichton mentioned this issue Apr 12, 2024
Merged
@alexcrichton
Copy link
Collaborator Author

I believe the second issue is #410, I'll retry the release once those are merged

abrown pushed a commit that referenced this issue Apr 15, 2024
@alexcrichton @abrown
Force-fetch tags in CI to fix git describe
b4f426a 
My release attempt in #408 did not go well because the release artifacts
were not named correctly. This fixes an issue described by
actions/checkout#290 where checkouts of annotated tags overwrite the
annotation which breaks `git describe`. That means that version
detection is broken in CI during releases which causes artifacts to have
the wrong information.

This applies the workaround described in that issue to `git fetch --tags
--force` after the checkout step to undo the overwrite done in the
checkout step.
@abrown
Copy link
Collaborator

abrown commented Apr 15, 2024

One issue is #409 where ./version.py was putting a git hash in the version number when it shouldn't. Another issue is CI built artifacts with a version number of 21.21... which should have been 22.0... and I am trying to figure out why and am being pretty unsuccessful.

Did my comment in #409 clear things up?

@alexcrichton
Copy link
Collaborator Author

Yeah sounds good! I'll try a re-tag now and see how it goes

@alexcrichton
Copy link
Collaborator Author

Ok https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-22 was produced just now and things look better. If other folks want to give some eyes on that I can hit the publish button later today or tomorrow.

@alexcrichton
Copy link
Collaborator Author

Ok I've hit publish.

@abrown
Copy link
Collaborator

abrown commented Apr 16, 2024

I opened #414 to see if I could figure out where the extra m suffix came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @abrown @sunfishcode