Fix a few users of single-thread TLS #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
force-pushed
the
single-thread-tls
branch
from
c03bc21 to
fa50e79
Compare
namely pthread_getattr_np and pthread_key_create/pthread_key_destroy. fixes: WebAssembly#617
yamt
force-pushed
the
single-thread-tls
branch
from
fa50e79 to
00b7c24
Compare
abrown
approved these changes
Aug 27, 2025
Collaborator
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
This makes sense to me. For future reference: the side effect here is that thread state will always be configured regardless of whether _REENTRANT is defined (i.e., all targets, not just *-threads). This is probably what we want after #602.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namely pthread_getattr_np and pthread_key_create/pthread_key_destroy.
fixes: #617