Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive mutex #433

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix recursive mutex #433

merged 1 commit into from
Aug 21, 2023

Commits on Aug 15, 2023

  1. Fix recursive mutex

    the robust mutex logic in musl seems to assume that
    the bit 29 of TIDs is always zero for some reasons.
    
    from https://git.musl-libc.org/cgit/musl/commit/?id=099b89d3840c30d7dd962e18668c2e6d39f0c626
    > note that the kernel ABI also reserves bit 29
    > not to appear in any tid,
    
    i'm not sure if the assumption is true or not, given that
    FUTEX_TID_MASK is 0x3fffffff.
    
    anyway, when using non-default type of mutex like recursive mutex,
    it causes problems as we actually use TID 0x3fffffff for the main thread.
    
    as we don't support robust mutex anyway, this commit simply
    comments out the problematic condition.
    
    fixes: bytecodealliance/wasm-micro-runtime#2466
    yamt committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a4e2218 View commit details
    Browse the repository at this point in the history