Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-headers: Generate assertions of layout from witx #149

Merged
merged 6 commits into from
Feb 7, 2020

Conversation

pchickey
Copy link
Collaborator

Serves as evidence that WebAssembly/WASI#181 is correct

@pchickey
Copy link
Collaborator Author

The CI doesn't actually build the libc. I tested locally with wasi-sdk 7:

/opt/wasi-sdk/bin/clang -c libc-bottom-half/headers/public/wasi/api.h

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

libc-bottom-half/headers/public/wasi/api.h Show resolved Hide resolved
tools/wasi-headers/src/c_header.rs Show resolved Hide resolved
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

libc-bottom-half/headers/public/wasi/api.h Outdated Show resolved Hide resolved
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output: lgtm
Rust code: i have not idea what i'm doing

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@pchickey
Copy link
Collaborator Author

pchickey commented Feb 7, 2020

Well, apparently I forgot to merge this right after returning for the new year, and it got out-of-date. I just rebased on master, pointed at the current wasi master, and regenerated header.

@sunfishcode sunfishcode merged commit c6f2c05 into master Feb 7, 2020
@sunfishcode sunfishcode deleted the pch/assert_memory_layout branch February 7, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants