Improve lexing of invalid annotations (fixes fuzz failure) #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Feb 25, 2023
This had been crashing even with annotations disabled. Adds a regression test. This was missed in #2001 when updating the parser to match the updated spec (WebAssembly/spec#1499). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53935
keithw
force-pushed
the
improve-annotation-parse
branch
from
478b0a9 to
828277f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wat2wasmhad been crashing on some invalid annotations, even with annotations disabled (as found by oss-fuzz in issue 53935).I missed this in #2001 when updating the parser to match the updated spec (WebAssembly/spec#1499). This PR fixes the lexer and adds a regression test.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53935
N.B. With annotations enabled,
wat2wasmseems to go into an infinite loop on this same input; will require further investigation.