Skip to content

Conversation

@marcusb
Copy link
Contributor

@marcusb marcusb commented Sep 22, 2022

No description provided.

@marcusb
Copy link
Contributor Author

marcusb commented Sep 22, 2022

@keithw

@marcusb
Copy link
Contributor Author

marcusb commented Sep 22, 2022

Not sure if I should also run ./test/update-spec-tests.py to add the new test cases, but those do not generally pass.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we can worry about any news tests in separate PRs.

@sbc100
Copy link
Member

sbc100 commented Sep 22, 2022

(Will wait for @keithw approval before landing)

@keithw
Copy link
Member

keithw commented Sep 22, 2022

lgtm. An update that runs update-spec-tests.py is at #2001; this brings in the new tokens.wast test, which requires a change to the Wast lexer to get everything passing.

@sbc100 sbc100 merged commit 6c5ff43 into WebAssembly:main Sep 22, 2022
@keithw keithw mentioned this pull request Oct 3, 2022
matthias-blume pushed a commit to matthias-blume/wabt that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants