-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arity of generated switcher continuations #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry, had missed this!
There seems to be some problem with the CI -- is this fixed upstream? |
Btw, can you do a PR to rename Handle to Prompt? |
Yes, absolutely. Maybe better if I do that in a separate PR? Regardless, the CI fails to install OCaml -- is this a known issue elsewhere? Do we need to update the workflow definition? |
Yes, separate PR. The CI issue probably is just a glitch. Those happen, just manually restart the workflow. |
I've restarted it multiple times already. Actually, it seems like the CI cannot install
|
I think what has happened is that the version of Edit: I think my analysis is correct, see ocaml/setup-ocaml#872 |
@rossberg I think we need to update the workflow to use |
IIRC, I already upgraded upstream last year. Maybe it'd be good to resync this one soon. |
8b1c068
to
2445f30
Compare
Yes. Should I merge with WebAssembly/spec main or branch wasm-3.0? The latter seems to have been updated last time in November. |
wasm-3.0, since that's the baseline here, isn't it? Only that has references and exceptions and all. |
OK. I will do two more PRs. One for renaming |
This patch fixes a bug with the arity of the continuation reference generated by a `switch` (aka the current continuation). Its arity was mistakenly derived from the switch-tag's codomain. The arity of the current continuation can be obtained at the `switch` point by deconstructing the type annotation on it.
2445f30
to
6579ef4
Compare
This patch fixes a bug with the arity of the continuation reference
generated by a
switch
(aka the current continuation). Its arity wasmistakenly derived from the switch-tag's codomain. The arity of the
current continuation can be obtained at the
switch
point bydeconstructing the type annotation on it.
Fixes #103.