[spec] Fix and clean up invariants for host functions #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
approved these changes
Sep 5, 2017
Member
binji
left a comment
binji
left a comment
There was a problem hiding this comment.
I just did a quick once-over, but it looks good to me.
Contributor
|
Hi Andreas We briefly discussed the possibility of removing the store constraints from the host function reduction rule, since they're not necessary any more. This is a stylistic choice, but it would make my model slightly prettier if I'm going for "eyeball-close" correspondence with the spec rules. Looks good to me in any case! |
Member
Author
|
@conrad-watt, right. Done, adjusting the text accordingly. PTAL. |
conrad-watt
reviewed
Sep 6, 2017
document/core/exec/instructions.rst
Outdated
| every :ref:`host function instance <syntax-funcinst>` must be :ref:`valid <valid-hostfuncinst>`, | ||
| which means that it adheres to suitable pre- and post-conditions: | ||
| under a :ref:`valid store <valid-store>` :math:`S`, and given arguments :math:`\val^n` matching the ascribed parameter types :math:`t_1^n`, | ||
| executing the host function must produce a valid store :math:`S'` that is an :ref:`extension <extend-store>` of :math:`S` and a result matching the ascribed result types :math:`t_2^m`. |
Contributor
There was a problem hiding this comment.
Possible nitpick: "result types" should be "result type"
rossberg
added a commit
that referenced
this pull request
Dec 9, 2024
Test out-of-bounds element segment indexing for `array.new_elem`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few random typos.
This change is inspired by discussion with Conrad Watt, who pointed out a problem with the previous formulation.