Fixed i32.wrap/i64 being parsed as i64.wrap/i64 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a partial set of tests for conversions
Member
|
lgtm |
Member
|
@AndrewScheidecker can you resolve conflicts so we can merge the issue? |
Contributor
|
LGTM. Please merge, I'm blocked on this |
Member
|
This has lgtms and is now mergable. Merging. |
sunfishcode
added a commit
that referenced
this pull request
Sep 17, 2015
Fixed i32.wrap/i64 being parsed as i64.wrap/i64
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
* Move unary instructions before binary instructions. Fix order of floating point unary ops. * Move reserved spaces for reciprocal sqrt and approx reciprocal to the end of the unary op blocks. * Move shifts in between unary and binary ops since they are kind of hybrid.
awendland
pushed a commit
to awendland/webassembly-spec-abstypes
that referenced
this pull request
Mar 26, 2020
* [js-api] Remove spurious argument to ToWebAssemblyValue(). Fixes WebAssembly#51. * [js-api] Extend the WebAssembly.Table API. Fixes WebAssembly#22. Fixes WebAssembly#67.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Aug 30, 2024
`switch.call` becomes `stack.new_switch` because it is the composition of `stack.new` (not yet documented) and `switch`. Similarly, `switch.return` becomes `switch_retire` because it performs a switch and retires the previous active stack. We use "retire" instead of "return" because "return" is not really an accurate description of what is happening.
rossberg
pushed a commit
that referenced
this pull request
Sep 4, 2024
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 21, 2024
Merge with WebAssembly/spec
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
stevenfontanella
pushed a commit
to stevenfontanella/spec
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was parsing i64.wrap/i64, but I believe that's an accidental divergence from the AstSemantics doc, so I changed it to i32.wrap/i64.
I also added tests for i64.extend_s/i32, i64.extend_u/i32, i32.wrap/i64, i32.trunc_s/f32, i32.trunc_u/f32, i64.trunc_s/f32, and i64.trunc_u/f32.
I had to use negative constants for some of the tests to work around an apparent bug that const.iXX doesn't handle values larger than the largest signed value for that integer size.