Implement unsigned operators #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For consistency and clear definitions, why not make all int ops work using big_int (of size 32 bits/64 bits, respectively)? I feel like that might be a good move for the proto. |
|
Looks generally good to me. This made me realize that, without a single-precision ieee754 type, we'll have a hard time representing the precise semantics of |
|
Forgot to git add the test file earlier. @kg, hm, not sure if that would be clearer. You would enlarge the int32/64 value domain with illegal values, and you'd have to implement the wrap-around masking manually. Currently, the hacks are at least localised in a few operators. |
Simplify build-test
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
* Remove float atomics * Use 0xfe as prefix byte * Add sign-extending conversion operators * Remove sign-extending atomic-operators (encoding proposal 3)
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Sep 18, 2019
ErikMcClure
pushed a commit
to innative-sdk/spec
that referenced
this pull request
Jun 15, 2020
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 10, 2023
- replaced exceptions with tags - removed let blocks - removed now unnecessary (unreachable)s The output of all examples is as before.
backes
pushed a commit
to backes/spec
that referenced
this pull request
Jul 12, 2023
Raise JS memory limit to 100
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Feb 13, 2024
…bAssembly#27) This patch brings the description of the proposed instruction set extension in sync with the reference implementation. It also fixes a few other bugs such as a dead link in the TOC and the syntax in the examples. The document still warrants a refactoring as some things could do with better explanations, some TODOs left to complete, and some of the examples still make use of deprecated features from the function-references proposal.
rossberg
pushed a commit
that referenced
this pull request
Sep 4, 2024
rossberg
pushed a commit
that referenced
this pull request
Sep 4, 2024
rossberg
pushed a commit
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukewagner, @kg, it's rather ugly, going through big_int, but seems to work.