Skip to content

Conversation

@kg
Copy link
Contributor

@kg kg commented Aug 21, 2015

Made test run output silent by default (unless it fails). Removed the warning for no expected output (you can uncomment to turn it back on).

ocamlbuild isn't run to build main.native by default anymore. You can do ./runtests.py --build if you want it to be built for you.

@rossberg
Copy link
Member

LGTM

I have another feature wish. Can the script check the exit code of the interpreter? Currently, if it fails with e.g. a syntax error, but there is no expected output, it is regarded okay. (I changed the interpreter today so that it returns a non-zero error code on any error.)

rossberg added a commit that referenced this pull request Aug 21, 2015
Less verbose runtests output. Don't ocamlbuild by default (pass --build as an arg to build).
@rossberg rossberg merged commit f1f1443 into WebAssembly:master Aug 21, 2015
@kg
Copy link
Contributor Author

kg commented Aug 21, 2015

It already checks the exit code.

self.assertEqual(0, exitCode, "test runner failed with exit code %i" % exitCode)

tee might have been swallowing the exit code, but I've taken it out, so you should be good.

@rossberg
Copy link
Member

rossberg commented Aug 21, 2015 via email

ErikMcClure pushed a commit to innative-sdk/spec that referenced this pull request Jun 15, 2020
Right now there is a spec assert that host call's iterable result and wasm have the same arity. There's no guarantee this is true. Instead we should probably throw a type error if they don't match. In the future, we could do the more JS-y approach and allow the arity of result to be at least the arity of the expected signature.
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Oct 3, 2023
dhil added a commit to dhil/webassembly-spec that referenced this pull request Jan 25, 2024
rossberg pushed a commit that referenced this pull request Jul 3, 2024
CharlieTap pushed a commit to CharlieTap/spec that referenced this pull request Sep 25, 2025
stevenfontanella pushed a commit to stevenfontanella/spec that referenced this pull request Nov 12, 2025
threads:
    WebAssembly/threads@00464f4e
  simd:
    WebAssembly/simd@77e7fdac
  bulk-memory-operations:
    WebAssembly/bulk-memory-operations@404b7e7b
  reference-types:
    WebAssembly/reference-types@774dd1d0

This change was automatically generated by `update-testsuite.sh`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants