Skip to content

Refactoring float32 and float64 prims into a single FloatPrims functor #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
commonlisp wants to merge 1 commit into from
Closed

Refactoring float32 and float64 prims into a single FloatPrims functor #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ml-proto/host/parser.mly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ open Source
open Ast
open Script


(* Position handling *)

let position_to_pos position =
Expand Down Expand Up @@ -36,8 +35,8 @@ let literal at s t =
match t with
| Types.Int32Type -> Values.Int32 (I32.of_string s) @@ at
| Types.Int64Type -> Values.Int64 (I64.of_string s) @@ at
| Types.Float32Type -> Values.Float32 (F32.of_string s) @@ at
| Types.Float64Type -> Values.Float64 (F64.of_string s) @@ at
| Types.Float32Type -> Values.Float32 (Values.F32.of_string s) @@ at
| Types.Float64Type -> Values.Float64 (Values.F64.of_string s) @@ at
with _ -> Error.error at "constant out of range"


Expand Down
94 changes: 0 additions & 94 deletions ml-proto/spec/f32.ml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ml-proto/spec/f32.mli
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ml-proto/spec/f32_convert.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
module F32 = Values.F32
module F64 = Values.F64

(* WebAssembly-compatible type conversions to f32 implementation *)

let make_nan_nondeterministic x = F32.mul x (F32.of_float 1.)
Expand Down
12 changes: 6 additions & 6 deletions ml-proto/spec/f32_convert.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
(* WebAssembly-compatible type conversions to f32 implementation *)

val demote_f64 : F64.t -> F32.t
val convert_s_i32 : I32.t -> F32.t
val convert_u_i32 : I32.t -> F32.t
val convert_s_i64 : I64.t -> F32.t
val convert_u_i64 : I64.t -> F32.t
val reinterpret_i32 : I32.t -> F32.t
val demote_f64 : Values.F64.t -> Values.F32.t
val convert_s_i32 : I32.t -> Values.F32.t
val convert_u_i32 : I32.t -> Values.F32.t
val convert_s_i64 : I64.t -> Values.F32.t
val convert_u_i64 : I64.t -> Values.F32.t
val reinterpret_i32 : I32.t -> Values.F32.t
94 changes: 0 additions & 94 deletions ml-proto/spec/f64.ml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ml-proto/spec/f64.mli
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ml-proto/spec/f64_convert.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
module F32 = Values.F32
module F64 = Values.F64

(* WebAssembly-compatible type conversions to f64 implementation *)

let make_nan_nondeterministic x = F64.mul x (F64.of_float 1.)
Expand Down
12 changes: 6 additions & 6 deletions ml-proto/spec/f64_convert.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
(* WebAssembly-compatible type conversions to f64 implementation *)

val promote_f32 : F32.t -> F64.t
val convert_s_i32 : I32.t -> F64.t
val convert_u_i32 : I32.t -> F64.t
val convert_s_i64 : I64.t -> F64.t
val convert_u_i64 : I64.t -> F64.t
val reinterpret_i64 : I64.t -> F64.t
val promote_f32 : Values.F32.t -> Values.F64.t
val convert_s_i32 : I32.t -> Values.F64.t
val convert_u_i32 : I32.t -> Values.F64.t
val convert_s_i64 : I64.t -> Values.F64.t
val convert_u_i64 : I64.t -> Values.F64.t
val reinterpret_i64 : I64.t -> Values.F64.t
Loading