This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Add integer widen/narrow conversions #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of changes due to formatting of the markdown table, but if you choose to "view in rich diff" you should see the changes more clearly. |
dtig
reviewed
Jul 31, 2019
v8 implementation orders narrow before widen, figured we can do that here too.
tlively
reviewed
Aug 1, 2019
tlively
reviewed
Aug 1, 2019
tlively
approved these changes
Aug 1, 2019
|
These had previous consensus, where we agreed they are useful to include, merging. |
golegen
pushed a commit
to golegen/v8
that referenced
this pull request
Aug 3, 2019
Based on the updates to spec at WebAssembly/simd#89 Change-Id: Ie60037e4de7a6953708a98c708afc9a820e6aa97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728347 Reviewed-by: Deepti Gandluri <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#63034}
|
Can these opcodes be renumbered to leave space for |
|
I was advised to put these opcodes at the end, I don't think these are finalized or anything yet, so it should be okay to renumber them. |
This was referenced Aug 13, 2019
Closed
Honry
pushed a commit
to Honry/simd
that referenced
this pull request
Oct 19, 2019
* Add integer widen/narrow conversions * Fix names, add explanation on signed/unsigned narrowing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
@billbudge
@dtig