Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec tests to not be polymorphic #155

Closed
jfbastien opened this issue Jan 29, 2018 · 2 comments
Closed

Update spec tests to not be polymorphic #155

jfbastien opened this issue Jan 29, 2018 · 2 comments
Assignees

Comments

@jfbastien
Copy link
Member

From CG-01-26:

Some of the tests import a module called spectest and import a function called print which is overloaded by the embedder. Each import re-imports it with a different signature, but that’s weird because WebAssembly itself doesn’t have overloading. That way you could implement the spectest module in WebAssembly. Same with kinds: a global and function could have the same name.

  • Andreas: we could remove it from core tests, but we should still make sure that it validates.
  • Luke: I like the principle of being able to implement standard library in WebAssembly.
  • Andreas: I would propose removing the print function from the spec tests. We should use assertions instead. It’s no longer relevant. We’ll still test imports, but it doesn’t have to be print.

POLL: unanimous consent to remove polymorphic imports.

AI: Dan to update spec tests to not be polymorphic.

@rossberg
Copy link
Member

Refers to WebAssembly/spec#650, PR is in progress at WebAssembly/spec#652.

@binji
Copy link
Member

binji commented May 9, 2018

This change landed; closing.

@binji binji closed this as completed May 9, 2018
esoterra pushed a commit to esoterra/meetings that referenced this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants