Fix null-handling for equals in test and polyfill
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equals specifically allows null inputs. Update the JS API tests and the polyfill to match.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 4, 2024
Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350946}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2024
Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350946}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2024
Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350946}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 11, 2024
…tring Builtins, a=testonly Automatic update from web-platform-tests [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350946} -- wpt-commits: f427091001d8e21333c4a7ed1bfa10379f1f767d wpt-pr: 47969
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Sep 12, 2024
…tring Builtins, a=testonly Automatic update from web-platform-tests [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350946} -- wpt-commits: f427091001d8e21333c4a7ed1bfa10379f1f767d wpt-pr: 47969
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 16, 2024
…tring Builtins, a=testonly Automatic update from web-platform-tests [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvanchromium.org> Commit-Queue: Adam Klein <adamkchromium.org> Cr-Commit-Position: refs/heads/main{#1350946} -- wpt-commits: f427091001d8e21333c4a7ed1bfa10379f1f767d wpt-pr: 47969 UltraBlame original commit: b18d279f4aa8fe1f9f1620b57282557fa43fd884
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 16, 2024
…tring Builtins, a=testonly Automatic update from web-platform-tests [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvanchromium.org> Commit-Queue: Adam Klein <adamkchromium.org> Cr-Commit-Position: refs/heads/main{#1350946} -- wpt-commits: f427091001d8e21333c4a7ed1bfa10379f1f767d wpt-pr: 47969 UltraBlame original commit: b18d279f4aa8fe1f9f1620b57282557fa43fd884
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 16, 2024
…tring Builtins, a=testonly Automatic update from web-platform-tests [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: WebAssembly/js-string-builtins#43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvanchromium.org> Commit-Queue: Adam Klein <adamkchromium.org> Cr-Commit-Position: refs/heads/main{#1350946} -- wpt-commits: f427091001d8e21333c4a7ed1bfa10379f1f767d wpt-pr: 47969 UltraBlame original commit: b18d279f4aa8fe1f9f1620b57282557fa43fd884
eqrion
approved these changes
Sep 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equals specifically allows null inputs. Update the JS API tests and the polyfill to match.