Update and improve tests #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thibaudmichaud
commented
Oct 3, 2023
thibaudmichaud
commented
- Update tests that relied on the old API, where export wrappers were allowed to return "non-promisified" results.
- Add new tests ported from the V8 test suite
- Avoid dependency on wasm exception handling
- Update tests that relied on the old API, where export wrappers were allowed to return "non-promisified" results. - Add new tests ported from the V8 test suite - Avoid dependency on wasm exception handling
| @@ -149,19 +152,21 @@ test(() => { | |||
| {suspending: 'first'}); | |||
| let instance = builder.instantiate({m: {import: wasm_js_import}}); | |||
| let wrapped_export = ToPromising(instance.exports.test); | |||
| assert_equals(42, wrapped_export()); | |||
| wrapped_export(); | |||
| // The global was updated synchronously. | |||
There was a problem hiding this comment.
Is it correct that with amends in PR #16 this global will not be updated synchronously.
There was a problem hiding this comment.
That is correct. But note that this PR has some downsides and it is not clear at this point whether it will make it into the proposal. Ping @fgmccabe who has been thinking about this issue recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.