Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"name" section for globals? #964

Closed
sunfishcode opened this issue Jan 22, 2017 · 2 comments
Closed

"name" section for globals? #964

sunfishcode opened this issue Jan 22, 2017 · 2 comments
Milestone

Comments

@sunfishcode
Copy link
Member

BinaryEncoding.md describes a "name" section, which contains names for defined functions. However, there is currently no section for names for defined memories, defined tables, defined globals, or types.

Is this intended? Obviously, function names are the most important of those, however when debugging code it would be nice to see things like get_global stack_pointer instead of get_global 3 or whatever.

@lukewagner
Copy link
Member

That's a good point. So we could just bake in more kinds of names into the fixed structure of the name section, or we could add some varu32 bitmap field (to the beginning of the names section) that declares which kinds of names are present. That would allow us to backwards-compatibly add new kinds of names in the future.

@sunfishcode sunfishcode modified the milestone: MVP Jan 31, 2017
@sunfishcode
Copy link
Member Author

I missed that #750 is already open, which covers this. Closing this issue to move the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants