Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include types, tables, labels, globals, and memories in binary format name section #750

Closed
AndrewScheidecker opened this issue Aug 5, 2016 · 6 comments
Milestone

Comments

@AndrewScheidecker
Copy link

I realize the name section is probably seen as a stopgap for a more expressive metadata section, but it would be nice if it could round trip the names that are in the text format. At a glance, it's missing names for imports, types, tables, and labels.

@sunfishcode sunfishcode added this to the MVP milestone Jan 31, 2017
@sunfishcode
Copy link
Member

It's also missing names for globals and memories.

And as a minor nit, there are no distinct names for imports; imports are imported into their respective entities' index spaces, such as the function index space, so for example the existing "name" section covers imported functions.

So to summarize, the wasm binary format currently doesn't have names for:

  • types
  • tables
  • labels
  • globals
  • memories

@sunfishcode sunfishcode changed the title Include imports, types, tables, and labels in binary format name section Include types, tables, labels, globals, and memories in binary format name section Jan 31, 2017
@ghost
Copy link

ghost commented Jan 31, 2017

Yes the import names would be converted by the function names. Could this issue subsume #861 and close that? Could the local names for functions be applied to the function arguments and thus also the import argument names? None of this is a show stopper.

@jfbastien
Copy link
Member

@AndrewScheidecker could you file a PR for this?

@AndrewScheidecker
Copy link
Author

@AndrewScheidecker could you file a PR for this?

Will do.

@nomeata
Copy link

nomeata commented Jan 7, 2020

JFTR, this seems to have evolved into a proposal at https://github.com/WebAssembly/extended-name-section

@binji
Copy link
Member

binji commented Jan 14, 2020

Thanks for that info @nomeata! Let's close this issue then.

@binji binji closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants