[Custom Descriptors] Add struct.new_desc #8057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and struct.new_default_desc instructions that take descriptor operands. These will replace the overload of struct.new and struct.new_default for types that have descriptors. It will be invalid to use the new instructions on types that do not have descriptors and to use the old instructions on types that do have descriptors. For now, to allow for a graceful transition, accept the old overloaded uses of struct.new and struct.new_default where the new instructions will eventually be required.
kripken
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and struct.new_default_desc instructions that take descriptor operands.
These will replace the overload of struct.new and struct.new_default for
types that have descriptors. It will be invalid to use the new
instructions on types that do not have descriptors and to use the old
instructions on types that do have descriptors.
For now, to allow for a graceful transition, accept the old overloaded
uses of struct.new and struct.new_default where the new instructions
will eventually be required.