[Custom Descriptors] Consider desc effects in HeapStoreOptimization #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeapStoreOptimization moves subsequent sets back into initial allocations, so it must ensure the set values can be reordered before all of the original set values that it will precede. If the allocation has a descriptor operand, then the set value must be reordered before that as well, but we were not checking that operand for effects. Fix it.
kripken
reviewed
Jul 31, 2025
| (func $no-reorder-nested | ||
| (local $struct (ref $struct)) | ||
| ;; As above, but now it is not the top-level allocation that traps, but | ||
| ;; rather its descriptor operand. We still cannot optimized. |
Member
There was a problem hiding this comment.
Suggested change
| ;; rather its descriptor operand. We still cannot optimized. | |
| ;; rather its descriptor operand. We still cannot optimize. |
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: (nop) |
Member
Author
There was a problem hiding this comment.
Indeed, the test was out of date. Fixed.
kripken
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeapStoreOptimization moves subsequent sets back into initial
allocations, so it must ensure the set values can be reordered before
all of the original set values that it will precede. If the allocation
has a descriptor operand, then the set value must be reordered before
that as well, but we were not checking that operand for effects. Fix it.