Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Eagerly create segments when parsing datacount #6958

Merged
merged 6 commits into from
Sep 20, 2024
Merged

[NFC] Eagerly create segments when parsing datacount #6958

merged 6 commits into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. [NFC-ish] Eagerly create Functions in binary parser 

    In preparation for using IRBuilder in the binary parser, eagerly create
Functions when parsing the function section so that they are already
created once we parse the code section. IRBuilder will require the
functions to exist when parsing calls so it can figure out what type
each call should have, even when there is a call to a function whose
body has not been parsed yet.

NFC except that some error messages change to include the new empty
functions.
    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8543f16 View commit details
    Browse the repository at this point in the history

  2. [NFC] Eagerly create segments when parsing datacount 

    The purpose of the datacount section is to pre-declare how many data
segments there will be so that engines can allocate space for them
and not have to back patch subsequent instructions in the code section
that refer to them. Once we use IRBuilder in the binary parser, we will
have to have the data segments available by the time we parse
instructions that use them, so eagerly construct the data segments when
parsing the datacount section.
    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b83bec4 View commit details
    Browse the repository at this point in the history

  3. skip unparsed functions when printing

    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8f4ca9f View commit details
    Browse the repository at this point in the history

  4. update and fix test of datacount error

    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8d8eb13 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into binary-parser-eager-funcs

    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    945a807 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'binary-parser-eager-funcs' into binary-parser-eager-data

    @tlively
    tlively committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4d0deb1 View commit details
    Browse the repository at this point in the history