[NFC] Avoid collecting unnecessary parents in OptimizeAddedConstants #6953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Sep 17, 2024
| struct Inner : public ExpressionStackWalker<Inner> { | ||
| void visitLocalGet(LocalGet* curr) { parentMap[curr] = getParent(); } | ||
|
|
||
| std::map<Expression*, Expression*> parentMap; |
There was a problem hiding this comment.
Looks like this can be std::unordered_map. I'd be curious if that makes a measurable difference.
There was a problem hiding this comment.
Good idea, it does help by 1%. Added.
There was a problem hiding this comment.
I'll separately see if the other class is likewise sped up with such a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the pass 20% faster.