SimplifyGlobals: Apply constant globals to segment offsets #6226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Jan 18, 2024
Comment on lines
+73
to
+75
| (drop | ||
| (global.get $use-defined) | ||
| ) |
Member
There was a problem hiding this comment.
Maybe use $use-imported too as a comparison?
Comment on lines
+33
to
+34
| ;; CHECK: (data $dropped "hello, world!") | ||
| (data $dropped "hello, world!") |
Member
Author
There was a problem hiding this comment.
It's a segment without an offset, so the pass has nothing to do there but also it should not error on it (there is a nullptr for the offset). I added a comment to clarify.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…ly#6226) We already applied such globals to other globals, but can do the same to offsets of data and element segments. Suggested in WebAssembly#6220
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already applied such globals to other globals, but can do the same to offsets
of data and element segments.
Suggested in #6220 (comment)