[NFC] Experiment with C++20 coroutines for expression traversal #5447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a gtest file that is only included in the build when using C++20 or greater that defines a generator utility in terms of C++20 coroutines and then uses that to define generators for traversing Expressions. Unlike our current traversal utilities, these generators leave control flow up to their callers, making it trivial to do things like stop the traversal early or run multiple traversals concurrently, for example to compare two expression trees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a gtest file that is only included in the build when using C++20 or greater
that defines a generator utility in terms of C++20 coroutines and then uses that
to define generators for traversing Expressions. Unlike our current traversal
utilities, these generators leave control flow up to their callers, making it
trivial to do things like stop the traversal early or run multiple traversals
concurrently, for example to compare two expression trees.