Remove externref #4633
Merged
Remove externref #4633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `Type::externref` and `HeapType::ext` and replace them with uses of anyref and any, respectively, now that we have unified these types in the GC proposal. For backwards compatibility, continue to parse `extern` and `externref` and maintain their relevant C API functions.
kripken
approved these changes
May 3, 2022
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I see some more stuff in scripts/wasm2js.js
src/binaryen-c.cpp
Outdated
| BinaryenType BinaryenTypeVec128(void) { return Type::v128; } | ||
| BinaryenType BinaryenTypeFuncref(void) { return Type::funcref; } | ||
| BinaryenType BinaryenTypeExternref(void) { return Type::externref; } | ||
| BinaryenType BinaryenTypeExternref(void) { return Type::anyref; } // Deprecate? |
Member
There was a problem hiding this comment.
Suggested change
| BinaryenType BinaryenTypeExternref(void) { return Type::anyref; } // Deprecate? | |
| BinaryenType BinaryenTypeExternref(void) { return Type::anyref; } // TODO Deprecate? |
2 tasks
tlively
added a commit
that referenced
this pull request
Aug 11, 2022
The GC proposal has split `any` and `extern` back into two separate types, so reintroduce `HeapType::ext` to represent `extern`. Before it was originally removed in #4633, externref was a subtype of anyref, but now it is not. Now that we have separate heaptype type hierarchies, make `HeapType::getLeastUpperBound` fallible as well.
tlively
added a commit
that referenced
this pull request
Aug 17, 2022
The GC proposal has split `any` and `extern` back into two separate types, so reintroduce `HeapType::ext` to represent `extern`. Before it was originally removed in #4633, externref was a subtype of anyref, but now it is not. Now that we have separate heaptype type hierarchies, make `HeapType::getLeastUpperBound` fallible as well.
tlively
added a commit
that referenced
this pull request
Aug 18, 2022
The GC proposal has split `any` and `extern` back into two separate types, so reintroduce `HeapType::ext` to represent `extern`. Before it was originally removed in #4633, externref was a subtype of anyref, but now it is not. Now that we have separate heaptype type hierarchies, make `HeapType::getLeastUpperBound` fallible as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Type::externrefandHeapType::extand replace them with uses ofanyref and any, respectively, now that we have unified these types in the GC
proposal. For backwards compatibility, continue to parse
externandexternrefand maintain their relevant C API functions.