Skip to content

Replace Type::expand() with an iterator-based approach #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 19, 2020
Merged

Replace Type::expand() with an iterator-based approach #3061

merged 8 commits into from
Aug 19, 2020

Conversation

@dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Aug 19, 2020

As a follow-up to #3012 (comment), this PR replaces Type::expand() incl. its usages with an iterator-based approach.

@dcodeIO dcodeIO changed the title Replace Type::expand() with an interator-based approach Replace Type::expand() with an iterator-based approach Aug 19, 2020
dcodeIO
dcodeIO commented Aug 19, 2020
View reviewed changes
@dcodeIO
Copy link
Contributor Author

dcodeIO commented Aug 19, 2020

Some early fuzzing

Invocations so far:
   FuzzExec: 2313
   CompareVMs: 580
   CheckDeterminism: 213
   Wasm2JS: 513
   Asyncify: 542

tlively
tlively reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@tlively tlively merged commit a18d30f into WebAssembly:master Aug 19, 2020
This was referenced Aug 20, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcodeIO @tlively