Allow test/passes tests to have arbitrary names, with a side file that has the passes #2532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t contains the passes
aheejin
approved these changes
Dec 16, 2019
Member
|
So even if there is also a pass called |
tlively
approved these changes
Dec 16, 2019
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Ah, I didn't even know we supported this. This will be useful tests that need a bunch of feature flags 👍
Member
Author
|
@aheejin yes, this checks for the existence of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already supported this, but required that the filename be a number.
This lets the name be anything, and we check if
*.passesexists for it.