Use opaque types for handle references#2473
Merged
kripken merged 4 commits intoWebAssembly:masterfrom Nov 26, 2019
Merged
Conversation
kripken
approved these changes
Nov 25, 2019
RReverser
commented
Nov 25, 2019
Member
Author
|
Looks like CI is failing here for the same reasons as on master (on macOS only), but otherwise should be good to go. @kripken can you merge please? (I don't have rights on this repo/org) |
Member
|
I'm trying to fix CI now in #2474 - after that lands, we can merge it here, then land. (Unless we are sure this can land without CI testing? That's not obvious to me.) |
Member
|
That other PR landed. |
Member
Author
I was ~sure only because I checked Travis logs and saw that all other builders passed tests successfully, and only macOS one failed to start.
But fixing the final builder is even better indeed :) |
This improves typechecking by verifying that user passes pointers of correct types.
Define a macro to point opaque references to C structs when used from C, and to actual C++ classes when used from C++. This fixes typecheck errors for internal usages of these reference types.
RReverser
force-pushed
the
opaque-types
branch
from
120c384 to
8849508
Compare
Member
|
Great, thanks @RReverser! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves typechecking by verifying that user passes pointers of correct types.